Skip to content

Update server functions for latest tf2 sdk branch#411

Merged
Ayuto merged 2 commits into
Source-Python-Dev-Team:masterfrom
laurirasanen:update_tf2_sdk
Sep 20, 2021
Merged

Update server functions for latest tf2 sdk branch#411
Ayuto merged 2 commits into
Source-Python-Dev-Team:masterfrom
laurirasanen:update_tf2_sdk

Conversation

@laurirasanen

Copy link
Copy Markdown

tf2 branch for hl2sdk updated recently. Some members in IServer and IVEngineServer have changed.

@CookStar

Copy link
Copy Markdown
Contributor

Is it necessary to export IServer::GetPublicAddress?

@Ayuto

Ayuto commented Sep 20, 2021

Copy link
Copy Markdown
Member

No, we already have a Python function for it. Moreover, we would need to export netadr_t to actually be able to use it. I also tend to simply remove IsInternalBuild as it should always return True for us. Anyways, thanks for the PR! I you update the PR, I would like to merge it. Otherwise I'm going to make the changes on my own tomorrow.

@laurirasanen

Copy link
Copy Markdown
Author

Thanks for the feedback. I've removed the extra functions.

@Ayuto

Ayuto commented Sep 20, 2021

Copy link
Copy Markdown
Member

Thank you!

@Ayuto Ayuto merged commit 70e71fe into Source-Python-Dev-Team:master Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants